fix(workflows): exempt catalog automation from PR-count confirmation - #4607
Open
WOLIKIMCHENG wants to merge 2 commits into
Open
WOLIKIMCHENG wants to merge 2 commits into
WOLIKIMCHENG wants to merge 2 commits into
Conversation
Clarify that repository-owned community extension, preset, and bundle workflows bypass the ordinary contributor confirmation gate only after successful validation and allowed catalog/docs updates. Add regression coverage for the runtime-imported instruction, draft PR configuration, and catalog-specific allowed files. Fixes github#4597
mnriem
added
the
triage-nice-to-have
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused workflow changes address the reported failure and include appropriate regression coverage.
Pull request overview
Exempts repository-owned community catalog workflows from contributor PR-count confirmation while preserving validation and file restrictions.
Changes:
- Adds exemption instructions to extension, preset, and bundle workflows.
- Adds regression coverage for runtime imports, draft PRs, and allowed files.
File summaries
| File | Description |
|---|---|
.github/workflows/add-community-extension.md |
Adds extension workflow exemption. |
.github/workflows/add-community-preset.md |
Adds preset workflow exemption. |
.github/workflows/add-community-bundle.md |
Adds bundle workflow exemption. |
tests/test_github_workflows.py |
Verifies exemption wiring and safety constraints. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Resolve the workflow-test conflict by retaining the gh-aw v0.88.7 parameterized coverage and folding the exemption and runtime-import assertions into the scoped community workflow contract test. Assisted-by: OpenAI Codex (model: gpt-5.6-terra, autonomous)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4597.
Repository-owned gh-aw workflows for community extensions, presets, and
bundles now explicitly skip the ordinary contributor open-PR confirmation
only after successful validation and allowed catalog/docs updates. Their
checked-in locks continue to runtime-import the workflow Markdown, so no
generated-lock update is needed.
This does not change the three-open-PR policy for ordinary contributor pull
requests, and it does not modify catalog or community documentation data.
Testing
.venv/bin/python -m pytest -p no:cacheprovider tests/test_github_workflows.py -q— 34 passedgh aw compile --no-emit --no-check-updatefor all three workflows — passedgit diff --check— passedAI Disclosure
OpenAI Codex assisted with implementation, tests, conflict resolution, and
review using gpt-5.6-terra (high), gpt-5.6-luna (medium), and gpt-5.6-sol
(xhigh) in autonomous mode. I reviewed and approved the final changes.