Skip to content

fix(workflows): exempt catalog automation from PR-count confirmation #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WOLIKIMCHENG wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −1
Open

fix(workflows): exempt catalog automation from PR-count confirmation #4607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49de035
fix(workflows): exempt catalog automation from PR-count confirmation
WOLIKIMCHENG Sep 16, 2026
6277d04
Merge origin/main into fix/4597-gh-aw-pr-count-exemption
WOLIKIMCHENG Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/add-community-bundle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,11 @@ repository README remains the source for the actual URLs.

Create one draft pull request.

This repository-owned gh-aw maintenance workflow does not perform the contributor
open-PR count check or request confirmation. After successful validation and
allowed catalog/docs file updates, emit the configured draft `create_pull_request`
safe output regardless of the submitter's or filing account's open PR count.

- New entry branch:
`community/${{ github.event.issue.number }}-add-<bundle-id>-bundle`
- Update branch:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/add-community-extension.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,11 @@ Find the existing row and update any changed fields in-place.

Create a pull request with the changes. Use this branch naming convention:

This repository-owned gh-aw maintenance workflow does not perform the contributor
open-PR count check or request confirmation. After successful validation and
allowed catalog/docs file updates, emit the configured draft `create_pull_request`
safe output regardless of the submitter's or filing account's open PR count.

- **New extension:** `add-<extension-id>-extension`
- **Update:** `update-<extension-id>-extension`

Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/add-community-preset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,11 @@ Find the existing row and update any changed fields in-place.

Create a pull request with the changes. Use this branch naming convention:

This repository-owned gh-aw maintenance workflow does not perform the contributor
open-PR count check or request confirmation. After successful validation and
allowed catalog/docs file updates, emit the configured draft `create_pull_request`
safe output regardless of the submitter's or filing account's open PR count.

- **New preset:** `add-<preset-id>-preset`
- **Update:** `update-<preset-id>-preset`

Expand Down
15 changes: 14 additions & 1 deletion tests/test_github_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@
"Do not modify any other files",
),
)
REPOSITORY_OWNED_DRAFT_PR_EXEMPTION = (
"This repository-owned gh-aw maintenance workflow does not perform the contributor "
"open-PR count check or request confirmation. After successful validation and "
"allowed catalog/docs file updates, emit the configured draft `create_pull_request` "
"safe output regardless of the submitter's or filing account's open PR count."
)


def _publish_workflow_steps() -> dict[str, dict[str, object]]:
Expand Down Expand Up @@ -440,8 +446,15 @@ def test_community_upgrade_preserves_activation_and_permission_guards(kind):
def test_community_upgrade_preserves_scoped_draft_pr_contract(
kind, label, catalog_file, docs_file, instruction
):
source_text, _, source, compiled = _agentic_workflow(f"add-community-{kind}")
source_text, compiled_text, source, compiled = _agentic_workflow(
f"add-community-{kind}"
)
assert instruction in source_text
assert REPOSITORY_OWNED_DRAFT_PR_EXEMPTION in " ".join(source_text.split())
assert (
f"{{{{#runtime-import .github/workflows/add-community-{kind}.md}}}}"
in compiled_text
)
outputs = _safe_output_config(compiled)
expected_outputs = {
"add_comment", "add_labels", "create_pull_request", "noop",
Expand Down