Narrow return type of Performance/PerformanceObserverEntryList.getEntriesByType by entry type literal - #64338
Draft
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 2 commits into
Draft
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 2 commits into
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 2 commits into
Conversation
Copilot started work on behalf of
Ryan Cavanaugh (RyanCavanaugh)
September 19, 2026 01:45
View session
…ByType Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix return type for performance.getEntriesByType in lib.dom.d.ts
Narrow return type of Performance/PerformanceObserverEntryList.getEntriesByType by entry type literal
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getEntriesByTypewas typed to always returnPerformanceEntryList(PerformanceEntry[]), even though the runtime result is always a specificPerformanceEntrysubclass determined by thetypeargument. This forced casts or caused false TS2339 errors, e.g.performance.getEntriesByType('navigation').some(e => e.type === 'reload')failed becausetypedoesn't exist onPerformanceEntry.Changes
lib.dom.d.ts: Added literal-string overloads togetEntriesByTypeon bothPerformanceandPerformanceObserverEntryList, mapping each known entry type to its concrete subclass, with the existingstringoverload retained as a fallback for unknown types:"navigation"→PerformanceNavigationTiming[]"resource"→PerformanceResourceTiming[]"mark"→PerformanceMark[]"measure"→PerformanceMeasure[]"paint"→PerformancePaintTiming[]"event"→PerformanceEventTiming[]"largest-contentful-paint"→LargestContentfulPaint[]lib.webworker.d.ts: Added the matching overload subset ("mark","measure","resource") since only those subclasses exist in the worker global scope.performanceGetEntriesByType.tscompiler test covering each overload and the generic fallback case.