Skip to content

Narrow return type of Performance/PerformanceObserverEntryList.getEntriesByType by entry type literal #64338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Narrow return type of Performance/PerformanceObserverEntryList.getEntriesByType by entry type literal #64338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f568fe
Initial plan
Copilot Sep 19, 2026
48a00d0
Add overloads for Performance/PerformanceObserverEntryList getEntries…
Copilot Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tsc/internal/bundled/libs/lib.dom.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27506,6 +27506,13 @@ interface Performance extends EventTarget {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Performance/getEntriesByType)
*/
getEntriesByType(type: "event"): PerformanceEventTiming[];
getEntriesByType(type: "largest-contentful-paint"): LargestContentfulPaint[];
getEntriesByType(type: "mark"): PerformanceMark[];
getEntriesByType(type: "measure"): PerformanceMeasure[];
getEntriesByType(type: "navigation"): PerformanceNavigationTiming[];
getEntriesByType(type: "paint"): PerformancePaintTiming[];
getEntriesByType(type: "resource"): PerformanceResourceTiming[];
getEntriesByType(type: string): PerformanceEntryList;
/**
* The **`mark()`** method creates a named PerformanceMark object representing a high resolution timestamp marker in the browser's performance timeline.
Expand Down Expand Up @@ -27861,6 +27868,13 @@ interface PerformanceObserverEntryList {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceObserverEntryList/getEntriesByType)
*/
getEntriesByType(type: "event"): PerformanceEventTiming[];
getEntriesByType(type: "largest-contentful-paint"): LargestContentfulPaint[];
getEntriesByType(type: "mark"): PerformanceMark[];
getEntriesByType(type: "measure"): PerformanceMeasure[];
getEntriesByType(type: "navigation"): PerformanceNavigationTiming[];
getEntriesByType(type: "paint"): PerformancePaintTiming[];
getEntriesByType(type: "resource"): PerformanceResourceTiming[];
getEntriesByType(type: string): PerformanceEntryList;
}

Expand Down
6 changes: 6 additions & 0 deletions tsc/internal/bundled/libs/lib.webworker.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8201,6 +8201,9 @@ interface Performance extends EventTarget {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Performance/getEntriesByType)
*/
getEntriesByType(type: "mark"): PerformanceMark[];
getEntriesByType(type: "measure"): PerformanceMeasure[];
getEntriesByType(type: "resource"): PerformanceResourceTiming[];
getEntriesByType(type: string): PerformanceEntryList;
/**
* The **`mark()`** method creates a named PerformanceMark object representing a high resolution timestamp marker in the browser's performance timeline.
Expand Down Expand Up @@ -8384,6 +8387,9 @@ interface PerformanceObserverEntryList {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceObserverEntryList/getEntriesByType)
*/
getEntriesByType(type: "mark"): PerformanceMark[];
getEntriesByType(type: "measure"): PerformanceMeasure[];
getEntriesByType(type: "resource"): PerformanceResourceTiming[];
getEntriesByType(type: string): PerformanceEntryList;
}

Expand Down
52 changes: 52 additions & 0 deletions tsc/testdata/baselines/reference/compiler/performanceGetEntriesByType.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
//// [tests/cases/compiler/performanceGetEntriesByType.ts] ////

//// [performanceGetEntriesByType.ts]
function pageWasReloaded(): boolean {
return performance
.getEntriesByType("navigation")
.some(entry => entry.type === "reload");
}

const marks = performance.getEntriesByType("mark");
marks[0].detail;

const measures = performance.getEntriesByType("measure");
measures[0].detail;

const paints = performance.getEntriesByType("paint");
paints[0].startTime;

const resources = performance.getEntriesByType("resource");
resources[0].initiatorType;

const events = performance.getEntriesByType("event");
events[0].processingStart;

const lcp = performance.getEntriesByType("largest-contentful-paint");
lcp[0].renderTime;

const generic = performance.getEntriesByType("something-unknown");
generic[0].entryType;


//// [performanceGetEntriesByType.js]
"use strict";
function pageWasReloaded() {
return performance
.getEntriesByType("navigation")
.some(entry => entry.type === "reload");
}
const marks = performance.getEntriesByType("mark");
marks[0].detail;
const measures = performance.getEntriesByType("measure");
measures[0].detail;
const paints = performance.getEntriesByType("paint");
paints[0].startTime;
const resources = performance.getEntriesByType("resource");
resources[0].initiatorType;
const events = performance.getEntriesByType("event");
events[0].processingStart;
const lcp = performance.getEntriesByType("largest-contentful-paint");
lcp[0].renderTime;
const generic = performance.getEntriesByType("something-unknown");
generic[0].entryType;
99 changes: 99 additions & 0 deletions tsc/testdata/baselines/reference/compiler/performanceGetEntriesByType.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
//// [tests/cases/compiler/performanceGetEntriesByType.ts] ////

=== performanceGetEntriesByType.ts ===
function pageWasReloaded(): boolean {
>pageWasReloaded : Symbol(pageWasReloaded, Decl(performanceGetEntriesByType.ts, 0, 0))

return performance
>performance .getEntriesByType("navigation") .some : Symbol(Array.some, Decl(lib.es5.d.ts, --, --))
>performance .getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)
>performance : Symbol(performance, Decl(lib.dom.d.ts, --, --))

.getEntriesByType("navigation")
>getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)

.some(entry => entry.type === "reload");
>some : Symbol(Array.some, Decl(lib.es5.d.ts, --, --))
>entry : Symbol(entry, Decl(performanceGetEntriesByType.ts, 3, 14))
>entry.type : Symbol(PerformanceNavigationTiming.type, Decl(lib.dom.d.ts, --, --))
>entry : Symbol(entry, Decl(performanceGetEntriesByType.ts, 3, 14))
>type : Symbol(PerformanceNavigationTiming.type, Decl(lib.dom.d.ts, --, --))
}

const marks = performance.getEntriesByType("mark");
>marks : Symbol(marks, Decl(performanceGetEntriesByType.ts, 6, 5))
>performance.getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)
>performance : Symbol(performance, Decl(lib.dom.d.ts, --, --))
>getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)

marks[0].detail;
>marks[0].detail : Symbol(PerformanceMark.detail, Decl(lib.dom.d.ts, --, --))
>marks : Symbol(marks, Decl(performanceGetEntriesByType.ts, 6, 5))
>detail : Symbol(PerformanceMark.detail, Decl(lib.dom.d.ts, --, --))

const measures = performance.getEntriesByType("measure");
>measures : Symbol(measures, Decl(performanceGetEntriesByType.ts, 9, 5))
>performance.getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)
>performance : Symbol(performance, Decl(lib.dom.d.ts, --, --))
>getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)

measures[0].detail;
>measures[0].detail : Symbol(PerformanceMeasure.detail, Decl(lib.dom.d.ts, --, --))
>measures : Symbol(measures, Decl(performanceGetEntriesByType.ts, 9, 5))
>detail : Symbol(PerformanceMeasure.detail, Decl(lib.dom.d.ts, --, --))

const paints = performance.getEntriesByType("paint");
>paints : Symbol(paints, Decl(performanceGetEntriesByType.ts, 12, 5))
>performance.getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)
>performance : Symbol(performance, Decl(lib.dom.d.ts, --, --))
>getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)

paints[0].startTime;
>paints[0].startTime : Symbol(PerformanceEntry.startTime, Decl(lib.dom.d.ts, --, --))
>paints : Symbol(paints, Decl(performanceGetEntriesByType.ts, 12, 5))
>startTime : Symbol(PerformanceEntry.startTime, Decl(lib.dom.d.ts, --, --))

const resources = performance.getEntriesByType("resource");
>resources : Symbol(resources, Decl(performanceGetEntriesByType.ts, 15, 5))
>performance.getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)
>performance : Symbol(performance, Decl(lib.dom.d.ts, --, --))
>getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)

resources[0].initiatorType;
>resources[0].initiatorType : Symbol(PerformanceResourceTiming.initiatorType, Decl(lib.dom.d.ts, --, --))
>resources : Symbol(resources, Decl(performanceGetEntriesByType.ts, 15, 5))
>initiatorType : Symbol(PerformanceResourceTiming.initiatorType, Decl(lib.dom.d.ts, --, --))

const events = performance.getEntriesByType("event");
>events : Symbol(events, Decl(performanceGetEntriesByType.ts, 18, 5))
>performance.getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)
>performance : Symbol(performance, Decl(lib.dom.d.ts, --, --))
>getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)

events[0].processingStart;
>events[0].processingStart : Symbol(PerformanceEventTiming.processingStart, Decl(lib.dom.d.ts, --, --))
>events : Symbol(events, Decl(performanceGetEntriesByType.ts, 18, 5))
>processingStart : Symbol(PerformanceEventTiming.processingStart, Decl(lib.dom.d.ts, --, --))

const lcp = performance.getEntriesByType("largest-contentful-paint");
>lcp : Symbol(lcp, Decl(performanceGetEntriesByType.ts, 21, 5))
>performance.getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)
>performance : Symbol(performance, Decl(lib.dom.d.ts, --, --))
>getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)

lcp[0].renderTime;
>lcp[0].renderTime : Symbol(LargestContentfulPaint.renderTime, Decl(lib.dom.d.ts, --, --))
>lcp : Symbol(lcp, Decl(performanceGetEntriesByType.ts, 21, 5))
>renderTime : Symbol(LargestContentfulPaint.renderTime, Decl(lib.dom.d.ts, --, --))

const generic = performance.getEntriesByType("something-unknown");
>generic : Symbol(generic, Decl(performanceGetEntriesByType.ts, 24, 5))
>performance.getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)
>performance : Symbol(performance, Decl(lib.dom.d.ts, --, --))
>getEntriesByType : Symbol(Performance.getEntriesByType, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --) ... and 3 more)

generic[0].entryType;
>generic[0].entryType : Symbol(PerformanceEntry.entryType, Decl(lib.dom.d.ts, --, --))
>generic : Symbol(generic, Decl(performanceGetEntriesByType.ts, 24, 5))
>entryType : Symbol(PerformanceEntry.entryType, Decl(lib.dom.d.ts, --, --))

Loading